fix(redisotel-native): use metric definition from otel/semconv/v1.38.0#3731
Merged
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Uses the name, desc, unit of `db.client.operation.duration`, `db.client.connection.count`, `db.client.connection.create_time`, `db.client.connection.wait_time`, `db.client.connection.pending_requests` defined by otel/semconv/v1.38.0/dbconv. The resolves the metric description part of redis#3730.
e4f7e57 to
309d292
Compare
Member
|
cc @elena-kolevska and @ofekshenawa may want to look into this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the name, desc, unit of
db.client.operation.duration,db.client.connection.count,db.client.connection.create_time,db.client.connection.wait_time,db.client.connection.pending_requestsdefined by otel/semconv/v1.38.0/dbconv.The resolves the metric description part of #3730.
Note
Low Risk
Low-risk change limited to OpenTelemetry metric instrument creation/metadata; main impact is potential changes to metric descriptions/units (and thus downstream dashboards/alerts) while names should remain semconv-aligned.
Overview
Switches
redisotel-nativeto use OpenTelemetrysemconv/v1.38.0/dbconvdefinitions when creating key DB client metrics.db.client.operation.duration,db.client.connection.count,db.client.connection.create_time,db.client.connection.wait_time, anddb.client.connection.pending_requestsnow derive their name/description/unit (and histogram instruments viadbconv.New*) from semconv instead of locally-specified strings.Written by Cursor Bugbot for commit bff657b. This will update automatically on new commits. Configure here.