Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@fengve thank you for contributing, do you think it makes sense to have this as a separate status - nil?

@ndyakov

Generally, we consider an empty value to be a correct state because it is not an error in the Redis protocol.

When we use Redis for caching(pseudocode):

data, err := redis.Get(key)
if err != nil && err != redis.ErrNil {
	return nil, err
}

data = getData()

redis.Set(key,data)

@fengve i agree with you that redis.Nil should not be considered an error response here, but what i would like to discuss is - if it should be attribute.String("status", "nil") instead of attribute.String("status", "ok"), since even in your case it shows cache miss and not a cache hit.

@ndyakov

You're right, this makes it easier to distinguish states. I've added the nil state.