Merged
Conversation
There is no Stringer on the channel struct, so using %s causes an error. Using %v to print the default representation instead.
cb031bd to
f8992de
Compare
ndyakov
approved these changes
Dec 2, 2025
Member
ndyakov
left a comment
There was a problem hiding this comment.
that seems correct, but i am wondering what information this will give us? Should we think about some identifier for those channels in the future?
Contributor
Author
I agree. The current error message was simply broken. I provided something that would work. But it doesn't mean it would be meaningful. I feel like it has to be updated to provide a clear error message, but this was out of the scope of my changes. And it would require some discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no Stringer on the channel struct, so using %s causes an error.
Using %v to print the default representation instead.