Conversation
This commit introduces an optional logger parameter to various structs. This enhancement allows users to provide custom logging implementations.
An issue will remain for direct calls to internal.Logger.Printf, as the call depth cannot be adjusted there without changing the function signature.
cb7a509 to
8bf1376
Compare
4b03ae0 to
f2406a6
Compare
wzy9607
reviewed
Nov 26, 2025
| legacyLoggerWithLevel.Errorf(ctx, format, v...) | ||
| return | ||
| } | ||
| cl.logger.ErrorContext(ctx, format, v...) |
Contributor
There was a problem hiding this comment.
Use ErrorContext etc. will cause inaccurate source log attr.
Should use cl.logger.Handler().Handleinstead when wrapping, see slog godoc Example (Wrapping).
Member
Author
There was a problem hiding this comment.
@ccoVeille Maybe you would like to check this.
@wzy9607 thank you for pointing this out
Contributor
There was a problem hiding this comment.
I feel like there is an error here, yes
it should be
cl.logger.ErrorContext(cl.printfToStructured(ctx, format, v...))I will fix it.
I created the printToStructured to be able to handle the right format
Member
Author
There was a problem hiding this comment.
maybe the fix was lost when you force pushed? Can we just add a test with slog that it will work as expected?
Contributor
|
I feel like this PR can be closed now, as #3622 replaces it |
Member
Author
|
closed in favour of #3622 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue the work on #3560 opened by @ccoVeille