fix(options): Add buffer sizes to failover. Update README#3468
Merged
Conversation
ndyakov
commented
Aug 11, 2025
ndyakov
commented
Aug 11, 2025
htemelski-oss
previously approved these changes
Aug 11, 2025
htemelski-oss
left a comment
Contributor
There was a problem hiding this comment.
Looks, good there are two minor things to change but they are already noted
Contributor
|
Hello @ndyakov , Here's a small suggestion: How about keeping the read/write buffer size of the sentinel client at 4KB? Since there's no need for the sentinel client to handle large data transfers or pipeline scenarios. |
Member
Author
|
@cxljs great idea! Feel free to work on that or open a separate issue so we can pick it up when possible. |
Contributor
|
OK, I'll submit a PR later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3465