Fix Data Race in hooksMixin When Using MinIdleConns and AddHook#2814
Merged
Conversation
Contributor
Author
|
@ofekshenawa |
Collaborator
|
Hey @RyoMiyashita ! |
ofekshenawa
approved these changes
Dec 10, 2023
Contributor
Author
|
@ofekshenawa |
This was referenced Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2730
Overview
This PR addresses a critical data race issue discovered in
hooksMixinwhenMinIdleConnsis set to a value greater than 1, andclient.AddHookis used concurrently.Problem
The data race was identified during test, specifically in scenarios where
MinIdleConnstriggers the creation of idle connections in a separate goroutine, whileclient.AddHookmodifies the hooks concurrently. This concurrent access and modification ofhooks.dialerled to a data race.Solution
To resolve this concurrency issue, the following modifications were made:
Introduced a
sync.Mutexin thehooksMixinstruct to ensure thread-safe operations.Implemented locking and unlocking around critical sections in
AddHookanddialHookmethods to prevent concurrent read/write conflicts.Adjusted the clone method in
hooksMixinto handle the mutex correctly, avoiding the copying of mutex state.I invite feedback and further review on these changes!