Skip to content

feat: support write the types of pointer of simple data types (#2745)#2753

Merged
ofekshenawa merged 4 commits intoredis:masterfrom
tzq0301:master
Oct 31, 2023
Merged

feat: support write the types of pointer of simple data types (#2745)#2753
ofekshenawa merged 4 commits intoredis:masterfrom
tzq0301:master

Conversation

@tzq0301
Copy link
Contributor

@tzq0301 tzq0301 commented Oct 11, 2023

No description provided.

@tzq0301 tzq0301 mentioned this pull request Oct 13, 2023
Closed
@ofekshenawa ofekshenawa linked an issue Oct 29, 2023 that may be closed by this pull request
[Feature request] HSet struct with pointer #2745
Closed
@ofekshenawa
Copy link
Collaborator

ofekshenawa commented Oct 29, 2023

Hey,
Do you think you might be able to write a unit test that validates this? WDYT?

@tzq0301
Copy link
Contributor Author

tzq0301 commented Oct 29, 2023

Hey, Do you think you might be able to write a unit test that validates this? WDYT?

Hello. I have added a unit test for WriteArg to test the behaviour of the simple data types and the pointer type of them.

The result of the unit test shows that WriteArg the value of the pointer of the simple data types have the same behaviour as the non-pointer types after the modification of internal/proto/writer.go in this PR.

@ofekshenawa ofekshenawa merged commit 15682e3 into redis:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ofekshenawa ofekshenawa ofekshenawa approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature request] HSet struct with pointer

2 participants

@tzq0301 @ofekshenawa