chore(deps): Updating otel/metric and fixing breaking changes#2569
Merged
Conversation
Signed-off-by: Vincent Boutour <bob@vibioh.fr>
vmihailenco
previously approved these changes
Apr 30, 2023
Collaborator
|
@ViBiOh thanks, but looks like |
Contributor
Author
Hi @vmihailenco , thanks for your reply. It seems that the issue is related to the uptrace-go library. I made a pull-request to update it, but it seems that |
Collaborator
|
@ViBiOh okay, I've just tagged uptrace-go v1.15. Could you update dependencies again and remove Go 1.18 from the build list? |
Latest otel version use atomic.Pointer which is a go1.19 feature, so we have to drop support for the go 1.18 Signed-off-by: Vincent Boutour <bob@vibioh.fr>
vmihailenco
approved these changes
May 1, 2023
Collaborator
|
@ViBiOh Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the recent changes in the opentelemetry-go package https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.15.0, we cannot use directly
"go.opentelemetry.io/otel/attribute".KeyValuebut need to wrap them with the option pattern