feat: Add support for new redis command CLIENT NO-TOUCH#2551
Closed
ktsivkov wants to merge 10 commits into
Closed
Conversation
Update commands_test.go
Update commands.go
move: commands to StatusCmd
Contributor
Author
|
@monkey92t hey, could you please review this one? |
Collaborator
|
Based on my understanding, this is a client state, not a regular command. It labels a network connection, and we should figure out how to handle similar commands. |
Merged
Contributor
Author
|
@monkey92t @SoulPancake
type baseClient struct {
...
connPool pool.Pooler // This here
Needs some more thought but what comes to my mind on the fly is either one of those...
// ClientNoTouch /or any other labeling command/ Creates and tags a new connection and returns it for use
cl := redis.ClientNoTouch()
cl.Get(...)
cl.Close()
|
Member
|
Hello @ktsivkov, would you like to resurrect this discussion and start over? If so, let me know. If you don't have the time or don't plan to work on this, let's close the PR. |
Member
|
Closing for inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2519