Add support for MODULE LOADEX command#2490
Conversation
|
How are you planning to test this ? @ktsivkov |
|
I will be unable to do it this week, but my idea is to add inside the testing script to pull one of the officially supported plugins and use it for the test. Unless you have a better idea that could be more lightweight? |
|
@ktsivkov I don't think you can do this that way - purely because you'll need a binary, guaranteed to be compatible on an OS, it's different for each user, etc. IMHO for this (specifically) you should validate the syntax of the command - i.e use a mock. |
# Conflicts: # commands.go
|
@chayim Was checking yesterday @SoulPancake's issue here go-redis/redismock#69 but it looks like that is not actually testing the command's syntax. Did you mean some other type of mock? |
|
@ktsivkov |
…d` to check that the loadex command fails as expected
|
@chayim I believe the PR is ready for a review. |
Co-authored-by: Anurag Bandyopadhyay <angbpy@gmail.com>
|
@monkey92t |
Adding tests for it is too tricky.
It requires the redis-server to be run with flag
--enable-module-command yesand the existance of an.sofile for the module to be loaded.implement #2405