Conversation
sterobin
approved these changes
Mar 25, 2022
Contributor
sterobin
left a comment
There was a problem hiding this comment.
Yaaaay! Thank you so much, @emmurphy1 So glad we finally broke down and got that addressed.
mjahoda
reviewed
Mar 28, 2022
mjahoda
approved these changes
Mar 28, 2022
Contributor
mjahoda
left a comment
There was a problem hiding this comment.
Except for one omission (I put a comment inline), it looks great to me. Thank you for this significant and long-term postponed change!
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.