Skip to content

issue-184 Removed the abstract tag from all templates#185

Merged
emmurphy1 merged 3 commits intomasterfrom
issue-184
Apr 13, 2022
Merged

issue-184 Removed the abstract tag from all templates#185
emmurphy1 merged 3 commits intomasterfrom
issue-184

Conversation

@emmurphy1
Copy link
Collaborator

No description provided.

@emmurphy1 emmurphy1 requested a review from a team as a code owner March 24, 2022 18:30
@emmurphy1 emmurphy1 changed the title issue-184 removed abstract from concept module issue-184 Removed the abstract tag from all templates Mar 24, 2022
Copy link
Contributor

@sterobin sterobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmurphy1 I've approved, but just pointing out that my understanding is that although the abstract tag indeed isn't required by tooling, which will pull the first paragraph as the abstract, it's a failsafe to ensure an abstract is pulled in the event that a writer doesn't include spacing between the header and the first paragraph. I believe both pv2 and Jupiter rely on the line break following the header and following the first paragraph are the delimiters for the abstract. Should anyone or anything (auto-generated content) disregard the line break(s), then the abstract tag would be the failsafe in that case. I could be wrong, but in case this comes up after we make this change, I wanted us to be aware.

I do agree though to ditch the tag regardless for the sake of vast majority of successful cases.


////
The `context` attribute enables module reuse. Every module ID includes {context}, which ensures that the module has a unique ID even if it is reused multiple times in a guide
The `context` attribute enables module reuse. Every module ID includes {context}, which ensures that the module has a unique ID even if it is reused multiple times in a guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider replacing the "guide" term with something already-defined or unequivocal - assembly of assemblies, an assembly that includes other assemblies, ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this in today's meeting and we will consider this after we start using Jupiter.

@vsodhi
Copy link

vsodhi commented Apr 13, 2022

LGTM.

@emmurphy1 emmurphy1 merged commit 1c22cc5 into master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants