fix: show all enums on hover#942
Merged
msivasubramaniaan merged 1 commit intoredhat-developer:mainfrom Dec 19, 2023
Merged
Conversation
Contributor
Author
|
cc @gorkem and @msivasubramaniaan for visibility. |
msivasubramaniaan
approved these changes
Dec 19, 2023
|
@msivasubramaniaan @twelvelabs This feature really broke our workflow, we use arrays where items are defined with a huge list of enums (and markdownEnumDescriptions), and now hover will not work as it tries to render the full list of enum instead of trying to show the markdownEnumDescription for the enum entry being hovered on first. I also think this feature has limited purpose as the list is available with autocompletion. I suggest to put this change behind a setting which can be disabled. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the hover service to display all possible enum values, rather than just the currently selected one. Additionally, it will display the enums regardless of whether the schema contains explicit descriptions (though it will continue to display the descriptions if present - see included test case).
Also:
ensureLineBreakhelper to make sure there is consistent spacing between each of the various hover sections.What issues does this PR fix or reference?
Fixes #941
Is it tested? How?
test/hover.test.ts