Skip to content

Handle circular aliasases#899

Merged
gorkem merged 2 commits intoredhat-developer:mainfrom
gorkem:circular-alias-fix
Jul 10, 2023
Merged

Handle circular aliasases#899
gorkem merged 2 commits intoredhat-developer:mainfrom
gorkem:circular-alias-fix

Conversation

@gorkem
Copy link
Collaborator

@gorkem gorkem commented Jun 25, 2023

What does this PR do?

Adds a check to skip AST conversion if a circular Alias is encountered.

What issues does this PR fix or reference?

Is it tested? How?

A new unit test added to parser tests

@coveralls
Copy link

Coverage Status

coverage: 83.788% (+0.03%) from 83.762% when pulling 92f8a98 on gorkem:circular-alias-fix into b2b129a on redhat-developer:main.

Adds a check to to skip ast conversion if a circular Alias
is encountered.
@gorkem gorkem force-pushed the circular-alias-fix branch from 92f8a98 to 11082b2 Compare July 7, 2023 15:28
@coveralls
Copy link

coveralls commented Jul 7, 2023

Coverage Status

coverage: 83.826% (+0.03%) from 83.8% when pulling adfd308 on gorkem:circular-alias-fix into c2c2979 on redhat-developer:main.

Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gorkem gorkem merged commit 88c6dae into redhat-developer:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recursive anchors crash extension

3 participants