Fix key ordering quickfix breaks YAML#1175
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Feb 10, 2026
Merged
Conversation
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
3658216 to
42b6a99
Compare
datho7561
approved these changes
Feb 10, 2026
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Looks good and works well. Thanks, Morgan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
key orderingquick fix cases where applying the fix breaks YAML layout or fail to apply.Reordering now keeps entries properly separated, one key per line.
Note that the one key per line is a newly added behavior. To make behavior consistent (I think), I made the rewriter to strip leading blank-line from entries so reordered entries stay one-per-line.
For example, given:
After reordering keys, we now get:
Reordering now works correctly when the map ends at EOF with a trailing newline. Previously, the quick fix could appear but produce no change when click-onto for inputs like (note the blank line at EOF):
Fixes by normalizing newline token handling at map boundaries and applying the replacement over the correct map range so the edit is always effective.
What issues does this PR fix or reference?
Fixes #1171
Is it tested? How?
Automated test + I tested manually.