Fix hover feature for YAML 1.1 boolean values#1156
Merged
datho7561 merged 2 commits intoredhat-developer:mainfrom Dec 15, 2025
Merged
Fix hover feature for YAML 1.1 boolean values#1156datho7561 merged 2 commits intoredhat-developer:mainfrom
datho7561 merged 2 commits intoredhat-developer:mainfrom
Conversation
added 2 commits
December 9, 2025 06:34
The equals() function was using JSON.parse() to convert boolean source strings, which fails for YAML 1.1 booleans like 'True', 'False', 'yes', 'no', etc. This change uses the existing parseYamlBoolean() function instead. Fixes redhat-developer#1152 Signed-off-by: Lawrence Troup <ltroup@cisco.com>
1 task
datho7561
approved these changes
Dec 15, 2025
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Looks good and fixes the issue. Thanks @lawrencetroup !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The equals() function was using JSON.parse() to convert boolean source strings, which fails for YAML 1.1 booleans like 'True', 'False', 'yes', 'no', etc. This resulted in hovering in files containing YAML 1.1 boolean values to fail with:
This change uses the existing
parseYamlBoolean()function instead to evaluate boolean equality.This fixes a regression introduced by commit
e6165e4(and4370b5c) which fixed #1078 and #1116 by changinggetNodeValue()to returnnode.sourcefor booleans, but theequals()function wasn't updated to handle all YAML 1.1 boolean string formats.What issues does this PR fix or reference?
This fixes #1152.
Is it tested? How?