Fix YAML JSON Schema files starting with %YAML 1.x#1073
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom May 26, 2025
Merged
Fix YAML JSON Schema files starting with %YAML 1.x#1073datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
3 tasks
datho7561
approved these changes
May 26, 2025
Contributor
datho7561
left a comment
There was a problem hiding this comment.
This change fixes the bug for me. Thanks!
Fix a bug where YAML files containing a JSON Schema that start with %YAML 1.x or a comment that contains a number would fail to to be parsed. This is caused by the fact that the JSON Schema parser would contain the number, e.g. 1.2 as the value of `unresolvedJsonSchema.schema` and so the test for `=== undefined` would fail. This would cause the error from the JSON parser to be returned instead of trying to parse the file as a YAML file. To work around this, also check if `unresolvedJsonSchema.schema` is a number. It if is, it clearly was not a JSON Schema and so we can safely try to parse the file as a YAML file. Fixes: redhat-developer#922 Signed-off-by: David Lechner <dlechner@baylibre.com>
75a3dd9 to
cb82e0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bug where YAML files containing a JSON Schema that start with %YAML 1.x or a comment that contains a number would fail to to be parsed.
This is caused by the fact that the JSON Schema parser would contain the number, e.g. 1.2 as the value of
unresolvedJsonSchema.schemaand so the test for=== undefinedwould fail. This would cause the error from the JSON parser to be returned instead of trying to parse the file as a YAML file.To work around this, also check if
unresolvedJsonSchema.schemais a number. It if is, it clearly was not a JSON Schema and so we can safely try to parse the file as a YAML file.What issues does this PR fix or reference?
Fixes: #922
Is it tested? How?
The modified test failed before the code change and passes after.