Fix corner case for 'flow sequence forbidden' quickfix#1061
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom May 8, 2025
Merged
Conversation
fb168d5 to
a31584b
Compare
ccbd2b2 to
0362918
Compare
- Do not include any trailing spaces in the error range
- This is a change in behaviour; it seems this behaviour was
intentional based on the test cases,
but I don't agree with it, since the error range should only cover
the erroneous code.
- Fix a bug where `]` or `}` are not included in the error range if they're the last character in the document
Fixes redhat-developer#1060
Signed-off-by: David Thompson <davthomp@redhat.com>
0362918 to
a291fa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
]or}are not included in the error range if they're the last character in the documentWhat issues does this PR fix or reference?
Fixes #1060
Is it tested? How?
Updated the unit tests to reflect that trailing whitespaces are not included in the range. The corner case of a flow sequence at the end of the document was already covered in the suite, but the expected range of the diagnostic was wrong.