showed error on unresolved alias#1059
Merged
msivasubramaniaan merged 3 commits intoredhat-developer:mainfrom May 6, 2025
Merged
showed error on unresolved alias#1059msivasubramaniaan merged 3 commits intoredhat-developer:mainfrom
msivasubramaniaan merged 3 commits intoredhat-developer:mainfrom
Conversation
datho7561
requested changes
Apr 29, 2025
datho7561
reviewed
Apr 29, 2025
| const startOffset = nodeRange[0]; | ||
| const endOffset = nodeRange[1]; | ||
| const range = Range.create(document.positionAt(startOffset), document.positionAt(endOffset)); | ||
| const warningDiagnostic = Diagnostic.create(range, `Unresolved alias "${node}"`, DiagnosticSeverity.Hint, 0); |
Contributor
There was a problem hiding this comment.
Also maybe worth adding "it will be treated as a string instead" into the error message
Contributor
Author
|
|
Contributor
|
Sorry, somehow this slipped through for me, I'll take another look |
datho7561
approved these changes
Apr 30, 2025
Contributor
datho7561
left a comment
There was a problem hiding this comment.
One more comment that I think you missed from last time, but it's fine to merge as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1098
What does this PR do?
This PR showed diagnostic error when there were no alias
What issues does this PR fix or reference?
redhat-developer/vscode-yaml#1098
Is it tested? How?
Yes added test case for the fix