Skip to content

fix: exclude not suggest properties from possible properties error#1051

Merged
msivasubramaniaan merged 4 commits intoredhat-developer:mainfrom
jigx-com:fix/exclude-not-suggest-properties-from-possible-properties-error
Apr 28, 2025
Merged

fix: exclude not suggest properties from possible properties error#1051
msivasubramaniaan merged 4 commits intoredhat-developer:mainfrom
jigx-com:fix/exclude-not-suggest-properties-from-possible-properties-error

Conversation

@p-spacek
Copy link
Contributor

What does this PR do?

suggested properties are filtered out if the schema contains doNotSuggest or deprecationMessage
this PR does the same for possibleProperties in validation error

What issues does this PR fix or reference?

no ref

Is it tested? How?

adds unit test

@coveralls
Copy link

coveralls commented Apr 22, 2025

Coverage Status

coverage: 84.109% (+0.03%) from 84.075%
when pulling 38de0f8 on jigx-com:fix/exclude-not-suggest-properties-from-possible-properties-error
into 4602af7 on redhat-developer:main.

Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msivasubramaniaan msivasubramaniaan merged commit 6e4ba83 into redhat-developer:main Apr 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants