fix for auto completion with escape sequence chars#1040
Conversation
2 similar comments
|
This doesn't fix issue for me. Make the following document, and open completion at the # yaml-language-server: $schema=https://raw.githubusercontent.com/RedCMD/TmLanguage-Syntax-Highlighter/main/vscode.tmLanguage.schema.json
|Accept the completion "New Grammar". The generated content is still broken. |
|
@datho7561 The autocomplete on parent level not be possible with escape chars. We have workaround only at the level of each key. Please try on the level of |
|
The bug report was about the completing the content using the "New Grammar" completion. In order to address the bug, the "New Grammar" completion should work as expected, with the quotes properly escaped when necessary. |
|
Yes but we can do the workaround only. Complete fix not be possible. I've tried it out fully. |
datho7561
left a comment
There was a problem hiding this comment.
Okay. We should keep the original issue open since this doesn't fix it, but I agree that this is worth merging because it addresses the issue you wrote a test case for.
|
Thank you Muthu, sorry for stalling the merge. |
What does this PR do?
This PR suggest characters with escape chars if needed
What issues does this PR fix or reference?
redhat-developer/vscode-yaml#1097
Is it tested? How?
Yes added test case for the fix