Fix ENUM yes no values#1038
Merged
msivasubramaniaan merged 5 commits intoredhat-developer:mainfrom Mar 20, 2025
Merged
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
datho7561
requested changes
Mar 12, 2025
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Something that might be worth addressing, but otherwise works well from my testing.
datho7561
approved these changes
Mar 19, 2025
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Works great! Thanks, Muthu!
|
Thanks for a quick turn around on this. |
|
I'd like to follow up on this PR and see when the update will be available for the YAML extension in VS Code? |
|
@msivasubramaniaan can you point us to information about the release schedule of this project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR suggests ENUM values based on type. Especially on the YAML spec 1.1 Boolean values like
on,off,true,false,yes,noWhat issues does this PR fix or reference?
fixes #1036
Is it tested? How?
Yes. Added test cases