Fix infinite $ref resolution loops#1195
Merged
datho7561 merged 2 commits intoredhat-developer:mainfrom Feb 25, 2026
Merged
Conversation
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
c980e0b to
75c1962
Compare
datho7561
approved these changes
Feb 25, 2026
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Morgan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
yamlSchemaService could keep expanding references forever and crash with heap/stack OOM when resolving schema with cyclic references.
Original implementation introduces a bug when $ref + siblings are rewritten to allOf and creates new nodes. This can cause dynamic ref paths to revisit the same resource repeatedly.
Fixed by:
WalkItem.siblingRefCycleKeysWhat issues does this PR fix or reference?
Fixes #1190
Is it tested? How?
Automated test and manually with this example:
When triggering auto-completion, expected to see 'no suggestion' instead of no response (keep loading).