Fix range of 'key ordering' error#1177
Merged
datho7561 merged 2 commits intoredhat-developer:mainfrom Feb 10, 2026
Merged
Conversation
Instead of reporting the range of the key and value, just report the range of the key. This helps to reduce visual clutter in the IDE due to the errors. Fixes redhat-developer#1172 Signed-off-by: David Thompson <davthomp@redhat.com>
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
shin19991207
approved these changes
Feb 10, 2026
Member
shin19991207
left a comment
There was a problem hiding this comment.
Looks good to me, and the fixes make the highlighted error clearer. Thanks, David.
I changed the loop to stop after the first match so it only highlights the first out of order element. Let me know if that makes sense.
Contributor
Author
|
Yes, that makes sense to me. Thanks for the review, Morgan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of reporting the range of the key and value, just report the range of the key. This helps to reduce visual clutter in the IDE due to the errors.
What issues does this PR fix or reference?
Fixes #1172
Is it tested? How?
Existing and new unit tests