Fix resolving schema content on web#1198
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Feb 6, 2026
Merged
Conversation
1 task
23b5278 to
964af21
Compare
shin19991207
reviewed
Feb 6, 2026
Use a new extension point, which requests schema content by URI instead of filepath. This is helpful, since web instances may use URIs with schemas other than `file://` to refer to the files in the workspace. Add a smoke test. Fixes redhat-developer#1194 Signed-off-by: David Thompson <davthomp@redhat.com>
964af21 to
953ff19
Compare
shin19991207
approved these changes
Feb 6, 2026
Member
shin19991207
left a comment
There was a problem hiding this comment.
Looks good to me and I tested manually without issues. Thanks David!
|
Will test on my side as soon as a pre-release is up - awesome! 🙌 |
Contributor
Author
|
ahh shoot, it's not working and one of my debug window notifications got released in the prerelease 🙃 . I'll need to release a patch that removes that notification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use a new extension point, which requests schema content by URI instead of filepath.
This is helpful, since web instances may use URIs with schemas other than
file://to refer to the files in the workspace.Add a smoke test.
Requires redhat-developer/yaml-language-server#1173
What issues does this PR fix or reference?
Fixes #1194
Is it tested? How?
New integration/smoke test