Merged
Conversation
rgrunber
reviewed
Sep 29, 2025
rgrunber
reviewed
Sep 29, 2025
cd18d31 to
c1b5587
Compare
rgrunber
approved these changes
Sep 30, 2025
Member
There was a problem hiding this comment.
LGTM, but I haven't tried it on a fork. Worth merging to get the pre-release going.
Just one thing. I think this will publish a new pre-release every day regardless of whether there's any new content. If you want to have it run daily, but only publish if there's actually new commits, you can add the following (sadly long) chunk :
It will provide an output of needs.should-build-change.outputs.repo-cache-hit, whose value is either true when there's a hit and can't be assumed to be anything else (ie. defined) otherwise.
Contributor
Author
|
Okay, I think I might as well add that from the start |
Fixes redhat-developer#1155 Signed-off-by: David Thompson <davthomp@redhat.com>
c1b5587 to
73a0465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Publishes nightly prerelease versions of vscode-yaml, using the latest yaml-language-server. Heavily inspired by https://github.com/redhat-developer/vscode-xml/blob/main/.github/workflows/release.yml
What issues does this PR fix or reference?
Fixes #1155
Is it tested? How?
I tested that the script I added to update the version number works, but the rest is tough to test without actually running the prelease.