Skip to content

Adjust to new hover behviour for enum#1030

Merged
rgrunber merged 1 commit intoredhat-developer:mainfrom
datho7561:fix-hover-test-content
Jun 6, 2024
Merged

Adjust to new hover behviour for enum#1030
rgrunber merged 1 commit intoredhat-developer:mainfrom
datho7561:fix-hover-test-content

Conversation

@datho7561
Copy link
Contributor

Signed-off-by: David Thompson davthomp@redhat.com

What does this PR do?

Fix the integration test for hover

What issues does this PR fix or reference?

The integration test for hover

Is it tested? How?

It's a fix to a test

@datho7561 datho7561 requested a review from rgrunber June 6, 2024 19:09
@datho7561
Copy link
Contributor Author

Tests pass locally for me. Is vscide-yaml using the right server version?

@datho7561
Copy link
Contributor Author

datho7561 commented Jun 6, 2024

If I try to set the yaml-language-server version to 1.15, then yarn build fails. Did the release go okay?

My bad I unlinked yaml-language-sever, which I didn't realize would remove it from the package.json entirely

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the fix-hover-test-content branch from 3fca201 to 4da5959 Compare June 6, 2024 19:38
@rgrunber rgrunber merged commit 98d0812 into redhat-developer:main Jun 6, 2024
@datho7561 datho7561 deleted the fix-hover-test-content branch June 6, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants