Add option to load related file into merged vars#25
Merged
Conversation
see GPTEINFRA-5776 and GPTEINFRA-5671 Add a new version of the 'related_files' entry in configuration file: 'related_file_v2'. The option provides a way to load the content of the file into a path. The path is JSON pointer format, like the other paths in the configuration (x-merge path in schema file.) Backward compatibility: Adding a new version of 'related_files' entry will ensure the previous one still works as expected across the different versions of the agV repos. Another solution would have been to support both list of strings and list of maps, but that would make the definition of the configuration less clear. We can also retire v1 later when it's been removed from all repos and not used anymore.
jkupferer
reviewed
Mar 17, 2023
jkupferer
approved these changes
Mar 17, 2023
- following up on getkin/kin-openapi#728 remove use of jsoninfo - Pin version of mergo to v0.3.12. v0.3.14 doesn't work the same or is buggy. - getSchemaList: Remove some unecessary step YAML->JSON, prefer JSON and data when possible
ab59cdf to
ecbe1ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see GPTEINFRA-5776 and GPTEINFRA-5671
Add a new version of the 'related_files' entry in configuration file: 'related_file_v2'.
The option provides a way to load the content of the file into a path.
The path is JSON pointer format, like the other paths in the configuration (x-merge path in schema file.)
Backward compatibility: Adding a new version of 'related_files' entry will ensure the previous one still works as expected across the different versions of the agV repos.
Another solution would have been to support both list of strings and list of maps, but that would make the definition of the configuration less clear. We can also retire v1 later when it's been removed from all repos and not used anymore.