Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Update prometheus-client#766

Merged
KTAtkinson merged 2 commits intoreddit:developfrom
SuperQ:bump_prom
Apr 6, 2023
Merged

Update prometheus-client#766
KTAtkinson merged 2 commits intoreddit:developfrom
SuperQ:bump_prom

Conversation

@SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Jan 24, 2023

💸 TL;DR

Update to the latest prometheus-client requirement. Mainly to pick up a reduction in multi-process worker overhead0.

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

Update to the latest prometheus-client requirement. Mainly to pick up a
reduction in multi-process worker overhead[0].

[0]: prometheus/client_python#853

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ requested a review from a team as a code owner January 24, 2023 06:44
@maeivysea
Copy link
Contributor

👋 could you link the relevant bits of the changelog? wanted to make sure the upgrade looks sane

Copy link
Contributor

@maeivysea maeivysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appeasing harold, feel free to re-tag

@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 26, 2023

@maeivysea I linked to the relevant PR in the commit message/PR title.

The two full changelogs for the versions we're upgrading to:

@SuperQ SuperQ requested review from KTAtkinson and maeivysea and removed request for maeivysea January 26, 2023 14:22
@maeivysea
Copy link
Contributor

apologies, i missed that in the commit message! thank you :)

@KTAtkinson KTAtkinson added v2.6 Pull requests to be included in v2.6 dependencies Pull requests that update a dependency file labels Apr 4, 2023
@KTAtkinson KTAtkinson merged commit 7f05b25 into reddit:develop Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file v2.6 Pull requests to be included in v2.6

Development

Successfully merging this pull request may close these issues.

3 participants