Setting NumPy version to 1.26 for compatibility with PyTorch 2.2.1+cu121#85
Merged
openshift-merge-bot[bot] merged 1 commit intored-hat-data-services:rhoai-2.8from Apr 3, 2025
Conversation
Signed-off-by: Snomaan6846 <syedali@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heyselbi, Snomaan6846 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
99b8efe
into
red-hat-data-services:rhoai-2.8
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Snomaan6846 syedali@redhat.com
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Jira Link : https://issues.redhat.com/browse/RHOAIENG-21889
Description
Higher version of numpy 2.2.4 was casuing incompatibility with torch version 2.2.1+cu121, Hence downgrading previous compatible numpy version 1.26.4.
Verification
docker run -it text-gen-server:0 bash
[tgis@0b5a8cc03691 app]$
[tgis@0b5a8cc03691 app]$ pip freeze|egrep 'numpy|torch'
DEPRECATION: Loading egg at /opt/tgis/lib/python3.11/site-packages/custom_kernels-0.0.0-py3.11-linux-x86_64.egg is deprecated. pip 25.1 will enforce this behaviour change. A possible replacement is to use pip for package installation. Discussion can be found at pypa/pip#12330
numpy==1.26.4
torch==2.2.1+cu121