Skip to content

[Symfony73] Fix Collection fields name usage on ConstraintOptionsToNamedArgumentsRector#851

Merged
samsonasik merged 2 commits intomainfrom
fix-colleciton-field
Oct 14, 2025
Merged

[Symfony73] Fix Collection fields name usage on ConstraintOptionsToNamedArgumentsRector#851
samsonasik merged 2 commits intomainfrom
fix-colleciton-field

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @TheoD02

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik enabled auto-merge (squash) October 14, 2025 15:35
@samsonasik samsonasik merged commit 3d39f6b into main Oct 14, 2025
5 checks passed
@samsonasik samsonasik deleted the fix-colleciton-field branch October 14, 2025 15:37
}

$args = $node->getArgs();
if ($className === 'Symfony\Component\Validator\Constraints\Collection'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use SymfonyClass enum by convention to keep classes at one place and to avoid prefixing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, updated 👍 #852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ConstraintOptionsToNamedArgumentsRector

2 participants