Add tests for overriding constructors in GetToConstructorInjectionRector#373
Closed
jackbentley wants to merge 1 commit intorectorphp:mainfrom
Closed
Add tests for overriding constructors in GetToConstructorInjectionRector#373jackbentley wants to merge 1 commit intorectorphp:mainfrom
jackbentley wants to merge 1 commit intorectorphp:mainfrom
Conversation
Member
|
I am closing it as it can be resolved by using rule among with AddConstructorParentCallRector |
Author
|
@samsonasik Tests still fail when adding that rule. |
Member
|
Ok, reopen then, feel free to provide a patch as well when you have a chance as well. I think the child parent param fill should be configurable per we discussed as |
Member
|
I am closing it, since as previoulsly stated, construct is special, and can be different with parent on purpose, that's the "real" override :) Feel free to open new PR if you have proposed safe solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.