Skip to content

[exp] [unambiguous] Add FluentSettersToStandaloneCallMethodRector #7625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 1 commit into from
Nov 13, 2025
Merged

[exp] [unambiguous] Add FluentSettersToStandaloneCallMethodRector #7625

TomasVotruba merged 1 commit into from
Nov 13, 2025

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Nov 13, 2025

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-remove-fluency-2 branch 2 times, most recently from ce93426 to 016a864 Compare November 13, 2025 20:30
@TomasVotruba TomasVotruba merged commit 86e4ac9 into main Nov 13, 2025
54 checks passed
@TomasVotruba TomasVotruba deleted the tv-remove-fluency-2 branch November 13, 2025 20:48
@VincentLanglet
Copy link
Contributor

VincentLanglet commented Nov 14, 2025

What if setName returns another entity ?

class SomeSetterClass
{
     public function setName(): Bar
     { return new Bar(); }
}

class Bar
{
     public function setSurname(): self
     { return $this; }
}

The rule is breaking the code:

(new SomeSetterClass())
            ->setName('John')
            ->setSurname('Doe')

no ?

@samsonasik
Copy link
Member

samsonasik commented Nov 14, 2025

@VincentLanglet oh, that's indeed cause invalid change https://getrector.com/demo/b6d4bf00-0c38-48fb-9bda-efdd12a21b8d

@samsonasik samsonasik mentioned this pull request Nov 14, 2025
Merged
@samsonasik
Copy link
Member

samsonasik commented Nov 14, 2025

@VincentLanglet I created PR

for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomasVotruba @VincentLanglet @samsonasik