[type-declaration] Add AddReturnTypeFromTryCatchTypeRector #7099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

TomasVotruba merged 5 commits into main from tv-try-catch

Jul 30, 2025

Member

TomasVotruba commented Jul 30, 2025

No description provided.

samsonasik reviewed

View reviewed changes

rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php Show resolved Hide resolved

samsonasik reviewed

View reviewed changes

rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php Show resolved Hide resolved

samsonasik reviewed

View reviewed changes

rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php Outdated Show resolved Hide resolved

TomasVotruba force-pushed the tv-try-catch branch 3 times, most recently from 6839803 to 794caed Compare

July 30, 2025 13:02

samsonasik reviewed

View reviewed changes

rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php Outdated Show resolved Hide resolved

TomasVotruba force-pushed the tv-try-catch branch 4 times, most recently from e451ff7 to 1da87a2 Compare

July 30, 2025 14:39

samsonasik requested changes

View reviewed changes

...aration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector/Fixture/skip_doc_type.php.inc Show resolved Hide resolved

samsonasik reviewed

View reviewed changes

rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php Outdated Show resolved Hide resolved

TomasVotruba force-pushed the tv-try-catch branch from 9a50ad3 to 1b25d9f Compare

July 30, 2025 14:48

TomasVotruba added 5 commits

July 30, 2025 16:52


          [type-declaration] Add AddReturnTypeFromTryCatchTypeRector

85db284


          use ClassMethodReturnTypeOverrideGuard

80038cd


          skip silent void

652a93f


          finalize classes

00db9a1


          [ci] fail on missed final class

c2d96ae

TomasVotruba force-pushed the tv-try-catch branch from 1b25d9f to c2d96ae Compare

July 30, 2025 14:52

TomasVotruba merged commit dc34f6c into main

47 checks passed

TomasVotruba deleted the tv-try-catch branch

July 30, 2025 15:00

Member

samsonasik commented Jul 30, 2025

I will add test+fix for try + catch + finally with different type in separate PR :)

samsonasik mentioned this pull request

[TypeDeclaration] Skip try catch finally different type on AddReturnTypeFromTryCatchTypeRector #7101

Merged

Member

samsonasik commented Jul 30, 2025

I created new PR for it:

[TypeDeclaration] Skip try catch finally different type on AddReturnTypeFromTryCatchTypeRector #7101

Contributor

github-actions bot commented Dec 28, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet