[Alternative 2] Make AddTypeToConstRector configurable to set inline_public config to allow non-final class to have typed constant #6975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…public config to allow non-final class to have typed constant
Member
|
I understand that for us Rector-geeks is easier to configure each rule as standalone :) but not for most users that just want to let Rector work for them = that's our mission after all, setup Rector and forget it exists, while getting most value of it. Goal of "treat all classes as final" is exactly to avoid configuring ~20 classes manually. I'll take the #6974 |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba this is the 2nd alternative for
The make
AddTypeToConstRectorso user can defineinline_publictheirself when needed to allow non-final class to have typed constant only on theAddTypeToConstRector.I prefer this option, as this feel less destructive, and more inline with other typed rules:
which has
inline_publicconfig that user can toggle on/off per specific rule.