fix: RenameMethodRector does not rename trait methods #6928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
May 26, 2025
samsonasik
reviewed
May 26, 2025
...ector/MethodCall/RenameMethodRector/Fixture/rename_trait_method_which_is_overwritten.php.inc
Show resolved
Hide resolved
samsonasik
reviewed
May 26, 2025
...ing/Rector/MethodCall/RenameMethodRector/Fixture/rename_method_which_is_not_in_trait.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
May 26, 2025
...ing/Rector/MethodCall/RenameMethodRector/Fixture/rename_method_which_is_not_in_trait.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
May 26, 2025
...ing/Rector/MethodCall/RenameMethodRector/Fixture/rename_method_which_is_not_in_trait.php.inc
Outdated
Show resolved
Hide resolved
Member
|
Let's give it a try, thank you @LordSimal |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: cakephp/upgrade#310
As we are currently trying to write configs to rename a whole bunch of methods for our newest major version of CakePHP we recognised, that the
RenameMethodRectordoes not work with traits (or at least not how we expected it to)How do we expect it to work?
Well if we configure rector with
it should
This is my crude implementation of how this could work.
I am - in fact - not really accustomed to this codebase so this could very well be a horrible hack in your opinion, so please bear with me 😅