Please correct me if I understood badly the implementation but if I understand correctly the usage of the kaizen option will be to run

vendor/bin/rector --kaizen=1

then

vendor/bin/rector --kaizen=2

then

vendor/bin/rector --kaizen=3

and so on.

If the first 10 rules don't make any change, I would have run 10 times for nothing, until

vendor/bin/rector --kaizen=11

do some change that I can review.

That could do the job, but what I had in mind had some extra-automation.

Like just running

vendor/bin/rector --kaizen

and rector does:

• Running rule 1, no change
• Running rule 2, no change
• ...
• Running rule 10, no change
• Running rule 11, a file change with the rule FooRule.
• Stop the process

Then I can commit the changes or ignore the rule and run again the kaizen option and the behavior will be

• Running rule 1, no change
• Running rule 2, no change
• ...
• Running rule 10, no change
• Running rule 11, no change (let's say I already commit the changes)
• Running rule 12, no change (for instance)
• Running rule 13, a file change with the rule BarRule

This way I'm saving rector runs.

It's a bit different. It should apply at least first X rules, where X is --kaizen X.

So if we run:

vendor/bin/rector --kaizen 2

It will apply first 2 rules that change anything.
So everyting you run this option, there will be some changes to review 👍

If there are no changes, it means all sets and rules are applied and vendor/bin/rector can be run instead.

Ok, so basically my usage would be to run

vendor/bin/rector --kaizen 1

and commiting changes (or ignoring the rule) between every run until a

vendor/bin/rector --kaizen 1

run cannot change anything and it means vendor/bin/rector can be now be use.

Exactly 👍

If you feel like you want to progress faster, e.g. when codebase is stable,
you can run e.g. --kaizen 3 or --kaizen 5 to apply more rules at a time.

Let's ship this to test in the wild 👍

@TomasVotruba @samsonasik @VincentLanglet

I am testing it, and it seems not work

# vendor/bin/rector --version
Rector 2.1.0
# vendor/bin/rector --kaizen 5

                               
  Command "5" is not defined.  
                               

@shakaran it seems using = is needed:

-vendor/bin/rector --kaizen 5
+vendor/bin/rector --kaizen=5

use = instead of space, see

use = instead of space, see

ok, confirmed, it works with =, thanks

I see, it because of missing "process", add "process" command and it works, so some trimming seems happen during it

for now, you can use = instead of space if you don't use "process" command explicitly.

@shakaran I created new PR to handle it:

• [Console] Handle hidden "process" with --option without = on ConsoleApplication #7022

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.