[Transform] Follow parent construct before add new param on StaticCallToMethodCallRector #6854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lToMethodCallRector
Member
Author
|
implemented /cc @parth391 Tested in both php 7.4 (with assign) and php 8.0 (with property promotion) 👍 |
5b8dda1 to
17c08b7
Compare
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Member
|
👍 |
Member
Author
|
I tested locally on 2 files extends single class, It only add
|
Member
Author
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9071
👍 If current class has
__construct, it already correct: https://getrector.com/demo/9663303c-6e55-40aa-a8f4-0c31790e2ae7❌ If current class doesn't have
__construct, and parent has, it should follow parent__construct, it currently not yet followed https://getrector.com/demo/2136fc0d-2973-409e-89c1-0a7ba83ad24fThis PR try to follow parent construct if no construct in current class.