Skip to content

[Php80] Handle crash on @testdoc with rector-phpunit AnnotationWithValueToAttributeRector #6846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsonasik merged 2 commits into from
Apr 18, 2025
Merged

[Php80] Handle crash on @testdoc with rector-phpunit AnnotationWithValueToAttributeRector #6846

samsonasik merged 2 commits into from
Apr 18, 2025

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 18, 2025 •
edited
Loading

It cause crash:

There was 1 error:

1) Rector\Tests\Issues\TestDocAnnotation\TestDocAnnotationTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc')
InvalidArgumentException: Name cannot be empty

/Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/Node/Name.php:254
/Users/samsonasik/www/rector-src/vendor/nikic/php-parser/lib/PhpParser/Node/Name.php:29
/Users/samsonasik/www/rector-src/src/PhpAttribute/AnnotationToAttributeMapper/ClassConstFetchAnnotationToAttributeMapper.php:37
/Users/samsonasik/www/rector-src/src/PhpAttribute/AnnotationToAttributeMapper.php:39
/Users/samsonasik/www/rector-src/src/PhpAttribute/AnnotationToAttributeMapper/ArrayAnnotationToAttributeMapper.php:49

Fixes rectorphp/rector#9120

The patch needs to be in rector-src so test is in here.

@samsonasik
Copy link
Member Author

samsonasik commented Apr 18, 2025

Fixed 🎉 /cc @mvhirsch

@samsonasik samsonasik mentioned this pull request Apr 18, 2025
Closed
@samsonasik
Copy link
Member Author

samsonasik commented Apr 18, 2025

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 6fb6fa4 into main Apr 18, 2025
45 checks passed
@samsonasik samsonasik deleted the crash-testdox branch April 18, 2025 16:44
@samsonasik samsonasik mentioned this pull request Apr 18, 2025
Merged
@mvhirsch
Copy link
Contributor

mvhirsch commented Apr 18, 2025

Thank you @samsonasik

@samsonasik
Copy link
Member Author

samsonasik commented Apr 18, 2025

It seems cause scoped error on website update

https://github.com/rectorphp/getrector-com/actions/runs/14539573071/job/40794730275?pr=2964#step:9:15

I will check

@samsonasik
Copy link
Member Author

samsonasik commented Apr 18, 2025

#6848

@samsonasik samsonasik mentioned this pull request Apr 19, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of AnnotationToAttributeRector

3 participants

@samsonasik @mvhirsch