Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Apr 14, 2025

… method on AddOverrideAttributeToOverriddenMethodsRector
@samsonasik
Copy link
Member Author

samsonasik commented Apr 14, 2025

@ruudk override empty non-native method and native __toString() override implemented 👍

todo: implements check on abstract traits, ref usecases:

for note: trait with no parent method and not abstract can't have #[Override] if no parent method https://3v4l.org/ACu8F

@samsonasik samsonasik marked this pull request as ready for review April 14, 2025 11:52
@samsonasik
Copy link
Member Author

implemented 🎉 /cc @ruudk @kochen

@samsonasik samsonasik requested a review from TomasVotruba April 14, 2025 11:52
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready 👍

@samsonasik
Copy link
Member Author

Let's merge 👍

@samsonasik samsonasik merged commit 0ca26f5 into main Apr 14, 2025
45 checks passed
@samsonasik samsonasik deleted the allow-override branch April 14, 2025 13:21
@TomasVotruba
Copy link
Member

Thank you 👏

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AddOverrideAttributeToOverriddenMethodsRector is not compatible with PHPStan's checkMissingOverrideMethodAttribute rule

3 participants