-
-
Notifications
You must be signed in to change notification settings - Fork 430
[Php83] Make configurable to allow add #[\Override] on override empty method on AddOverrideAttributeToOverriddenMethodsRector #6831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… method on AddOverrideAttributeToOverriddenMethodsRector
|
@ruudk override empty non-native method and native todo: implements check on abstract traits, ref usecases:
for note: trait with no parent method and not abstract can't have |
|
All checks have passed 🎉 @TomasVotruba I think it is ready 👍 |
|
Let's merge 👍 |
|
Thank you 👏 |
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Closes rectorphp/rector#9068