[PhpParser] Re-add back get value from __DIR__ and __FILE__ on ValueResolver#6756
Merged
samsonasik merged 3 commits intomainfrom Feb 24, 2025
Merged
[PhpParser] Re-add back get value from __DIR__ and __FILE__ on ValueResolver#6756samsonasik merged 3 commits intomainfrom
samsonasik merged 3 commits intomainfrom
Conversation
Member
Author
|
@TomasVotruba this is bring test on first commit for rectorphp/rector#9035, without the patch, the result test will failure: There was 1 failure:
1) Rector\Tests\Issues\GetValueMagicDir\GetValueMagicDirTest::test with data set #0 ('/home/runner/work/rector-src/...hp.inc')
Failed on fixture file "fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
{
public function run()
{
- 'tests/Issues/GetValueMagicDir/Fixture';
- 'tests/Issues/GetValueMagicDir/Fixture/fixture.php';
+ '__DIR__';
+ '__FILE__';see https://github.com/rectorphp/rector-src/actions/runs/13496093011/job/37703584689?pr=6756 |
Member
Author
Member
Author
|
Add more use case for array add more use case for inside array |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Member
|
👍 |
staabm
reviewed
Feb 24, 2025
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9035