[type-declaration] Add typed property, if traits do not duplicate the property#6663
Merged
TomasVotruba merged 2 commits intomainfrom Jan 9, 2025
Merged
[type-declaration] Add typed property, if traits do not duplicate the property#6663TomasVotruba merged 2 commits intomainfrom
TomasVotruba merged 2 commits intomainfrom
Conversation
b5ea2db to
1dd1843
Compare
samsonasik
reviewed
Jan 9, 2025
| return (bool) $this->betterNodeFinder->findFirst( | ||
| $trait, | ||
| function (Node $node) use ($propertyName): bool { | ||
| if (! $node instanceof Assign) { |
Member
There was a problem hiding this comment.
This should cover assign op, eg $this->props .= "append"; as well, using attribute key is_being_assigned should be more reliable.
Also needs to verify if property is being unset() via trait.
, i will check it.
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.