Use autowired method if exists in adding new dependency#6652
Merged
TomasVotruba merged 2 commits intomainfrom Jan 6, 2025
Merged
Use autowired method if exists in adding new dependency#6652TomasVotruba merged 2 commits intomainfrom
TomasVotruba merged 2 commits intomainfrom
Conversation
836b37e to
23def85
Compare
b532c86 to
56afd54
Compare
acae7c7 to
5394ff6
Compare
Member
|
I am updating rector-symfony fixture test at: |
Member
|
Let's re-run the build ... |
Member
Author
|
👍 |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using ctor over existing autowired method usually breaks child/parent class that uses constructor.
That's why this service should stick with already existing way to pass service dependencies.