Add always config for EncapsedStringsToSprintfRector#6050
Merged
TomasVotruba merged 1 commit intorectorphp:mainfrom Jun 27, 2024
Merged
Add always config for EncapsedStringsToSprintfRector#6050TomasVotruba merged 1 commit intorectorphp:mainfrom
always config for EncapsedStringsToSprintfRector#6050TomasVotruba merged 1 commit intorectorphp:mainfrom
Conversation
samsonasik
reviewed
Jun 27, 2024
rules-tests/CodingStyle/Rector/Encapsed/EncapsedStringsToSprintfRector/AlwaysSprintfTest.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Jun 27, 2024
...SprintfRector/FixtureAlwaysSprintf/encapsed_strings_to_sprintf_should_escape_percent.php.inc
Outdated
Show resolved
Hide resolved
Fixes rectorphp/rector#8690 This makes it possible to always convert to sprintf.
samsonasik
approved these changes
Jun 27, 2024
Member
|
Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8690
This makes it possible to always convert to sprintf.
@TomasVotruba @samsonasik Please let me know what you think. I need some inspiration for the config key.