Skip to content

[Naming] Handle used in arrow function param, then used again outer ArrowFunction on RenameParamToMatchTypeRector#6046

Merged
TomasVotruba merged 8 commits intomainfrom
naming-rename-arrow
Jun 26, 2024
Merged

[Naming] Handle used in arrow function param, then used again outer ArrowFunction on RenameParamToMatchTypeRector#6046
TomasVotruba merged 8 commits intomainfrom
naming-rename-arrow

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Jun 26, 2024

@samsonasik samsonasik changed the title [Naming] Handle used in arrow function param on RenameParamToMatchTypeRector [Naming] Handle used in arrow function param, then used again outer ArrowFunciton on RenameParamToMatchTypeRector Jun 26, 2024
@samsonasik samsonasik changed the title [Naming] Handle used in arrow function param, then used again outer ArrowFunciton on RenameParamToMatchTypeRector [Naming] Handle used in arrow function param, then used again outer ArrowFunction on RenameParamToMatchTypeRector Jun 26, 2024
@samsonasik samsonasik marked this pull request as draft June 26, 2024 12:18
@samsonasik
Copy link
Copy Markdown
Member Author

It seems happen on closure as well https://getrector.com/demo/94516435-ab7a-4928-aae4-310f5fde630b

@samsonasik samsonasik force-pushed the naming-rename-arrow branch from 11383ed to d361763 Compare June 26, 2024 15:14
@samsonasik samsonasik marked this pull request as ready for review June 26, 2024 15:14
@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉

@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba
Copy link
Copy Markdown
Member

LGTM 👍

@TomasVotruba TomasVotruba merged commit 716ee0b into main Jun 26, 2024
@TomasVotruba TomasVotruba deleted the naming-rename-arrow branch June 26, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of RenameParamToMatchTypeRector

3 participants