Skip to content

[DX] Introduce set providers, to enable package + version based set registration#5976

Merged
TomasVotruba merged 10 commits intomainfrom
tv-prepared-sets-twig-2
Jun 20, 2024
Merged

[DX] Introduce set providers, to enable package + version based set registration#5976
TomasVotruba merged 10 commits intomainfrom
tv-prepared-sets-twig-2

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Jun 18, 2024

@TomasVotruba TomasVotruba marked this pull request as draft June 19, 2024 01:13
@TomasVotruba TomasVotruba force-pushed the tv-prepared-sets-twig-2 branch 2 times, most recently from b7d2325 to c0bc5ed Compare June 20, 2024 00:56
@TomasVotruba TomasVotruba changed the title improve set map Improve set map Jun 20, 2024
@TomasVotruba TomasVotruba force-pushed the tv-prepared-sets-twig-2 branch from c0bc5ed to d3e967f Compare June 20, 2024 01:03
@TomasVotruba TomasVotruba changed the title Improve set map [DX] Introduce set providers, to enable package + version based set registration Jun 20, 2024
@TomasVotruba TomasVotruba marked this pull request as ready for review June 20, 2024 01:05
@TomasVotruba TomasVotruba force-pushed the tv-prepared-sets-twig-2 branch 4 times, most recently from 6e0912d to 7bc1597 Compare June 20, 2024 02:57
@TomasVotruba TomasVotruba force-pushed the tv-prepared-sets-twig-2 branch 4 times, most recently from 34eb192 to 1704677 Compare June 20, 2024 06:02
@TomasVotruba TomasVotruba marked this pull request as draft June 20, 2024 07:06
@TomasVotruba TomasVotruba force-pushed the tv-prepared-sets-twig-2 branch from 1704677 to c1fd131 Compare June 20, 2024 14:30
@TomasVotruba TomasVotruba marked this pull request as ready for review June 20, 2024 14:32
@TomasVotruba TomasVotruba force-pushed the tv-prepared-sets-twig-2 branch from c1fd131 to 70fa2e0 Compare June 20, 2024 14:34
@TomasVotruba TomasVotruba force-pushed the tv-prepared-sets-twig-2 branch from ae8c1be to 4279d5a Compare June 20, 2024 14:38
@TomasVotruba TomasVotruba force-pushed the tv-prepared-sets-twig-2 branch from abd1032 to c48b4d3 Compare June 20, 2024 14:41
@TomasVotruba
Copy link
Copy Markdown
Member Author

Ready to go. Mergin to test in the rector-symfony package 👍

@TomasVotruba TomasVotruba enabled auto-merge (squash) June 20, 2024 14:51
@TomasVotruba TomasVotruba merged commit 2dda748 into main Jun 20, 2024
@TomasVotruba TomasVotruba deleted the tv-prepared-sets-twig-2 branch June 20, 2024 14:52
@dozer111
Copy link
Copy Markdown

dozer111 commented Nov 7, 2024

this feature is amazing

why dont you write an article or a page in your site?

@TomasVotruba
Copy link
Copy Markdown
Member Author

Good point ☝️ I'll get to that next week

@TomasVotruba
Copy link
Copy Markdown
Member Author

We're getting closer to finish :)

I've improved the feature to take package version into an account: #6428

Post and documentation is ready on getrector.com repository as well rectorphp/getrector-com#2672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants