[Performance] Ensure call $reflector->reflectAllClasses() once on Worker take 3#5878
Merged
samsonasik merged 6 commits intomainfrom May 14, 2024
Merged
[Performance] Ensure call $reflector->reflectAllClasses() once on Worker take 3#5878samsonasik merged 6 commits intomainfrom
samsonasik merged 6 commits intomainfrom
Conversation
This was referenced May 14, 2024
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
Member
Author
|
@mfn @dorrogeray please try latest dev-main, it should be better now :), I will keep on if there is a better way to improve it. Current latest on rector-src code base itself: Before 58.689 seconds After 48.629 seconds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mfn @dorrogeray here another effort to improve performance of
DynamicSourceLocatorProvider, make it onCacheobject and save collection of classnames into cache, so$reflector->reflectAllClasses(), later, only calls the$this->reflectionProvider->getClass()from cache class names.Closes rectorphp/rector#8637
Closes rectorphp/rector#8638
Before
After