[CodingStyle] Remove usage of Reflection::expandClassName() from nette/utils 4.0 as cause bug on downgrade#5740
Merged
samsonasik merged 4 commits intomainfrom Mar 19, 2024
Merged
Conversation
…e/utils 4.0 as cause bug on downgrade
samsonasik
commented
Mar 19, 2024
|
|
||
| #[Route(path: '/pro/{id}/networks/{networkId}/sectors', name: 'api_network_sectors', requirements: ['id' => '\d+', 'networkId' => '\d+'])] | ||
| #[IsGranted('TEST')] | ||
| #[\Symfony\Component\Security\Http\Attribute\IsGranted('TEST')] |
Member
Author
There was a problem hiding this comment.
@TomasVotruba this is only drawback for this, as this consist of rename + make attribute, and run twice will auto-import it, see fixture https://github.com/rectorphp/rector-src/pull/5740/files#diff-fe6ad097b1f7d2f4670de3d6f764aabffb83f16862d8d7893e464012e0be1702
which I think it is ok :)
Member
Author
There was a problem hiding this comment.
It seems it can be tweaked with original name check, I created new PR to cover it:
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The syntax of downgrade
PhpToken::tokenize()and it usage call another method with->is()usage is too complex to downgrade.I think this usage can be removed.
Closes rectorphp/getrector-com#2142
Closes rectorphp/rector#8565