[Config] Handle $rectorConfig->import() with wildcards * config#4832
[Config] Handle $rectorConfig->import() with wildcards * config#4832TomasVotruba merged 4 commits intomainfrom
Conversation
|
@TomasVotruba I added e2e test for wilcards path import config to prove it :) 43d4bbf |
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
|
@samsonasik I'm afraid the current change doesn't seem to fix the issue completely, only the somewhat incomplete MRE I had presented. I've updated the repository and the issue with appropriate description and instructions to reproduce, but in short the proposed code only imports one file matching the wildcard and not all of them, which is the expected behavior. PS: I could not find a good way to directly import the branch as a composer dependency (I'm guessing because there's a build step?), so I applied the very small changes manually. |
|
@TomasVotruba @rmobis @staabm I updated e2e test for multi configs included test for the prove :) 29cae3d |
|
Seems to be working now. Thanks for the quick fix. |
|
You change my mind with easyfix :) ... Let's ship it then 👍 |
|
In hindsight, we're moving away from magic Let's keep Rector simple and explicit, like other PHP CLI tools are 👍 Reverting here: #5010 |
|
@TomasVotruba Fair enough. However, may I suggest we add a mention to this breaking change in the release notes? Either 0.18 or 0.18.3. Just so that people can easily find out why a previously working behavior now breaks. |
|
I'll update the 0.18 notes, thanks for feedback |
Fixes rectorphp/rector#8151
Hi @rmobis, this should handle
$rectorConfig->import()with wildcards * config. Could you verify this? Thank you.