Skip to content

Skip PHPDoc return type in AddReturnTypeDeclarationBasedOnParentClassMethodRector#4809

Merged
samsonasik merged 1 commit intorectorphp:mainfrom
staabm:phpdoc-test
Aug 17, 2023
Merged

Skip PHPDoc return type in AddReturnTypeDeclarationBasedOnParentClassMethodRector#4809
samsonasik merged 1 commit intorectorphp:mainfrom
staabm:phpdoc-test

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Aug 17, 2023

the rule did not yet contain a test which covers how it behaves with PHPDocs

@staabm staabm requested a review from TomasVotruba as a code owner August 17, 2023 14:51
@samsonasik samsonasik merged commit 8d74e1c into rectorphp:main Aug 17, 2023
@samsonasik
Copy link
Copy Markdown
Member

Thank you @staabm

@TomasVotruba
Copy link
Copy Markdown
Member

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants